diff options
| author | Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com> | 2014-09-16 14:37:25 +0200 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2014-09-25 10:52:04 +0200 |
| commit | 46b05c7bd51edafb8c8da088b49bddf7f78d48f9 (patch) | |
| tree | 8d20b253fd3ddbe544ae9e7df0a86a1388dc7528 /drivers/s390 | |
| parent | s390/tape: fix MTIOCGET ioctl to report blocksize (diff) | |
| download | linux-46b05c7bd51edafb8c8da088b49bddf7f78d48f9.tar.xz linux-46b05c7bd51edafb8c8da088b49bddf7f78d48f9.zip | |
s390/zcrypt: Fixed possible race condition in zcrypt module handling
Signed-off-by: Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/crypto/zcrypt_api.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 0e18c5dcd91f..08f1830cbfc4 100644 --- a/drivers/s390/crypto/zcrypt_api.c +++ b/drivers/s390/crypto/zcrypt_api.c @@ -343,10 +343,11 @@ struct zcrypt_ops *__ops_lookup(unsigned char *name, int variant) break; } } + if (!found || !try_module_get(zops->owner)) + zops = NULL; + spin_unlock_bh(&zcrypt_ops_list_lock); - if (!found) - return NULL; return zops; } @@ -359,8 +360,6 @@ struct zcrypt_ops *zcrypt_msgtype_request(unsigned char *name, int variant) request_module("%s", name); zops = __ops_lookup(name, variant); } - if ((!zops) || (!try_module_get(zops->owner))) - return NULL; return zops; } EXPORT_SYMBOL(zcrypt_msgtype_request); |