diff options
| author | Finn Thain <fthain@telegraphics.com.au> | 2016-01-03 06:05:38 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2016-01-07 03:43:00 +0100 |
| commit | 010e89d18c4e66ab69d64bab439eba988d16fcc9 (patch) | |
| tree | c22ad62f6201a609b72ae0192bcbf3aa06333c0b /drivers/scsi/NCR5380.h | |
| parent | ncr5380: Use work_struct instead of delayed_work (diff) | |
| download | linux-010e89d18c4e66ab69d64bab439eba988d16fcc9.tar.xz linux-010e89d18c4e66ab69d64bab439eba988d16fcc9.zip | |
ncr5380: Standardize work queueing algorithm
The complex main_running/queue_main mechanism is peculiar to
atari_NCR5380.c. It isn't SMP safe and offers little value given that
the work queue already offers concurrency management. Remove this
complexity to bring atari_NCR5380.c closer to NCR5380.c.
It is not a good idea to call the information transfer state machine from
queuecommand because, according to Documentation/scsi/scsi_mid_low_api.txt
that could happen in soft irq context. Fix this.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/NCR5380.h')
| -rw-r--r-- | drivers/scsi/NCR5380.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/NCR5380.h b/drivers/scsi/NCR5380.h index 7ffcb0c33a22..78af75142342 100644 --- a/drivers/scsi/NCR5380.h +++ b/drivers/scsi/NCR5380.h @@ -262,7 +262,6 @@ struct NCR5380_hostdata { * transfer to handle chip overruns */ int retain_dma_intr; struct work_struct main_task; - volatile int main_running; #ifdef SUPPORT_TAGS struct tag_alloc TagAlloc[8][8]; /* 8 targets and 8 LUNs */ #endif |