diff options
| author | Al Viro <viro@ftp.linux.org.uk> | 2007-10-29 06:08:38 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-29 15:41:33 +0100 |
| commit | db3a91fe2b425c9adde47069efebdba44e665cef (patch) | |
| tree | 85137ad8531f2dfa667bad11c82116c8f5feed48 /drivers/scsi/arcmsr/arcmsr.h | |
| parent | fix abuses of ptrdiff_t (diff) | |
| download | linux-db3a91fe2b425c9adde47069efebdba44e665cef.tar.xz linux-db3a91fe2b425c9adde47069efebdba44e665cef.zip | |
deal with resource allocation bugs in arcmsr
a) for type B we should _not_ iounmap() acb->pmu; it's not ioremapped.
b) for type B we should iounmap() two regions we _do_ ioremap.
c) if ioremap() fails, we need to bail out (and clean up).
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/scsi/arcmsr/arcmsr.h')
| -rw-r--r-- | drivers/scsi/arcmsr/arcmsr.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 3c38cd8d7117..a67e29f83ae5 100644 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -348,14 +348,6 @@ struct MessageUnit_B uint32_t __iomem *ioctl_rbuffer_reg; }; -struct MessageUnit -{ - union - { - struct MessageUnit_A pmu_A; - struct MessageUnit_B pmu_B; - } u; -}; /* ******************************************************************************* ** Adapter Control Block @@ -375,7 +367,6 @@ struct AdapterControlBlock uint32_t outbound_int_enable; union { - struct MessageUnit * pmu; struct MessageUnit_A __iomem * pmuA; struct MessageUnit_B * pmuB; }; |