diff options
| author | Jitendra Bhivare <jitendra.bhivare@avagotech.com> | 2016-01-20 09:40:45 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2016-02-24 03:27:02 +0100 |
| commit | 6ac999efeeff98f203eda8cf46d5016e99f58b0c (patch) | |
| tree | 01af7f763c301355719201b7b531072c78bc5415 /drivers/scsi/be2iscsi/be_main.c | |
| parent | Merge tag 'nfs-for-4.5-4' of git://git.linux-nfs.org/projects/trondmy/linux-nfs (diff) | |
| download | linux-6ac999efeeff98f203eda8cf46d5016e99f58b0c.tar.xz linux-6ac999efeeff98f203eda8cf46d5016e99f58b0c.zip | |
be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx
We are taking mbox_lock spinlock which disables pre-emption before we
poll for mbox completion. Waiting there with spinlock held in excess of
20s will cause soft lockup.
Actual fix is to change mbox_lock to mutex. The changes are done in
phases. This is the first part.
1. Changed mgmt_get_all_if_id to use MCC where after posting lock is
released.
2. Changed be_mbox_db_ready_wait to busy wait for 12s max and removed
wait_event_timeout. Added error handling code for IO reads.
OPCODE_COMMON_QUERY_FIRMWARE_CONFIG mbox command takes 8s time when
unreachable boot targets configured.
Signed-off-by: Jitendra Bhivare <jitendra.bhivare@avagotech.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/be2iscsi/be_main.c')
0 files changed, 0 insertions, 0 deletions