diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-05-07 10:53:45 +0200 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2010-05-24 18:11:03 +0200 |
| commit | e6b50c30fa8d46c9401c2d48eee2351bdbb4c51c (patch) | |
| tree | eea4f5077ba4367bde3bffb89545abb5eb08ad77 /drivers/scsi/be2iscsi/be_mgmt.c | |
| parent | fbmem: avoid printk format warning with 32-bit resources (diff) | |
| download | linux-e6b50c30fa8d46c9401c2d48eee2351bdbb4c51c.tar.xz linux-e6b50c30fa8d46c9401c2d48eee2351bdbb4c51c.zip | |
[SCSI] be2iscsi: correct return value in mgmt_invalidate_icds()
This function should return 0 on error. Returning -1 would cause a
crash.
Also there is an extra space before the newline character and a missing
space between the "for" and the "mgmt_invalidate_icds". I put the string
on one line. The current version of checkpatch.pl complains that the
line is too long, but it makes grepping easier.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/be2iscsi/be_mgmt.c')
| -rw-r--r-- | drivers/scsi/be2iscsi/be_mgmt.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index e641922f20bc..350cbeaae160 100644 --- a/drivers/scsi/be2iscsi/be_mgmt.c +++ b/drivers/scsi/be2iscsi/be_mgmt.c @@ -167,10 +167,9 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba, &nonemb_cmd.dma); if (nonemb_cmd.va == NULL) { SE_DEBUG(DBG_LVL_1, - "Failed to allocate memory for" - "mgmt_invalidate_icds \n"); + "Failed to allocate memory for mgmt_invalidate_icds\n"); spin_unlock(&ctrl->mbox_lock); - return -1; + return 0; } nonemb_cmd.size = sizeof(struct invalidate_commands_params_in); req = nonemb_cmd.va; |