diff options
| author | Jayamohan Kallickal <jayamohan.kallickal@emulex.com> | 2014-05-06 03:41:25 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-05-28 18:13:14 +0200 |
| commit | 0598b8afd65d6b0893d217f7cf77ea315cdfcb5b (patch) | |
| tree | 8d70a64d7c9288e6636f89c9d99fcb5087e17334 /drivers/scsi/be2iscsi | |
| parent | be2iscsi: Fix retrieving MCCQ_WRB in non-embedded Mbox path (diff) | |
| download | linux-0598b8afd65d6b0893d217f7cf77ea315cdfcb5b.tar.xz linux-0598b8afd65d6b0893d217f7cf77ea315cdfcb5b.zip | |
be2iscsi: Fix exposing Host in sysfs after adapter initialization is complete
Before probe for function was completed, iSCSI Daemon had initiated login
to target while OS was coming up. The targets which had node.startup=automatic,
login process was initiated.Since function specific initialization was still in
progress this lead to kernel panic.
Fixed the issue by moving iscsi_host_add() call after adapter initialization
is done.
Signed-off-by: John Soni Jose <sony.john-n@emulex.com>
Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/be2iscsi')
| -rw-r--r-- | drivers/scsi/be2iscsi/be_main.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 0d822297aa80..a73af296b29d 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -599,15 +599,7 @@ static struct beiscsi_hba *beiscsi_hba_alloc(struct pci_dev *pcidev) pci_set_drvdata(pcidev, phba); phba->interface_handle = 0xFFFFFFFF; - if (iscsi_host_add(shost, &phba->pcidev->dev)) - goto free_devices; - return phba; - -free_devices: - pci_dev_put(phba->pcidev); - iscsi_host_free(phba->shost); - return NULL; } static void beiscsi_unmap_pci_function(struct beiscsi_hba *phba) @@ -5621,6 +5613,9 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev, } hwi_enable_intr(phba); + if (iscsi_host_add(phba->shost, &phba->pcidev->dev)) + goto free_blkenbld; + if (beiscsi_setup_boot_info(phba)) /* * log error but continue, because we may not be using |