diff options
author | Ajish Koshy <Ajish.Koshy@microchip.com> | 2022-01-24 09:22:55 +0100 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-01-31 18:14:49 +0100 |
commit | c26b85ea16365079be8d206b20556a60a0c69ad4 (patch) | |
tree | 82eaac4ada83a7d7081c22bb12249a4785a3a1d9 /drivers/scsi/bnx2fc/bnx2fc_fcoe.c | |
parent | scsi: myrs: Fix crash in error case (diff) | |
download | linux-c26b85ea16365079be8d206b20556a60a0c69ad4.tar.xz linux-c26b85ea16365079be8d206b20556a60a0c69ad4.zip |
scsi: pm80xx: Fix double completion for SATA devices
Current code handles completions for SATA devices in mpi_sata_completion()
and mpi_sata_event().
However, at the time when any SATA event happens, for almost all the event
types, the command is still in the target. It is therefore incorrect to
complete the task in sata_event().
There are some events for which we get sata_completions, some need recovery
procedure and others abort. All the tasks must be completed via
sata_completion() path.
Removed the task done related code from sata_events(). For tasks where we
don't get completions, let top layer call abort() to abort the command post
timeout.
Link: https://lore.kernel.org/r/20220124082255.86223-1-Ajish.Koshy@microchip.com
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Co-developed-by: Viswas G <Viswas.G@microchip.com>
Signed-off-by: Viswas G <Viswas.G@microchip.com>
Signed-off-by: Ajish Koshy <Ajish.Koshy@microchip.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/bnx2fc/bnx2fc_fcoe.c')
0 files changed, 0 insertions, 0 deletions