diff options
| author | Mike Christie <michael.christie@oracle.com> | 2022-08-12 03:00:24 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-09-07 04:05:59 +0200 |
| commit | ebb54b201c9378f08053b461898d15c019aaf4ba (patch) | |
| tree | 3bd2d7a7e5c0ff76452c36873297ff4424b3c13d /drivers/scsi/cxlflash | |
| parent | scsi: qla2xxx: Drop DID_TARGET_FAILURE use (diff) | |
| download | linux-ebb54b201c9378f08053b461898d15c019aaf4ba.tar.xz linux-ebb54b201c9378f08053b461898d15c019aaf4ba.zip | |
scsi: cxlflash: Drop DID_ALLOC_FAILURE use
DID_ALLOC_FAILURE is internal to the SCSI layer. Drivers must not use it
because:
1. It's not propagated upwards, so SG IO/passthrough users will not see an
error and think a command was successful.
2. There is no handling for it in scsi_decide_disposition() so it results
in entering SCSI error handling.
By the code comment, it looks like the driver wanted a retryable error
code, so this has it use DID_ERROR.
Link: https://lore.kernel.org/r/20220812010027.8251-8-michael.christie@oracle.com
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/cxlflash')
| -rw-r--r-- | drivers/scsi/cxlflash/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index e7be95ee7d64..cd1324ec742d 100644 --- a/drivers/scsi/cxlflash/main.c +++ b/drivers/scsi/cxlflash/main.c @@ -132,7 +132,7 @@ static void process_cmd_err(struct afu_cmd *cmd, struct scsi_cmnd *scp) break; case SISL_AFU_RC_OUT_OF_DATA_BUFS: /* Retry */ - scp->result = (DID_ALLOC_FAILURE << 16); + scp->result = (DID_ERROR << 16); break; default: scp->result = (DID_ERROR << 16); |