diff options
| author | Finn Thain <fthain@telegraphics.com.au> | 2017-08-04 07:43:19 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-08-11 01:55:34 +0200 |
| commit | 201c37d7bf121474ab08212ec0a1e9b163bdd74f (patch) | |
| tree | 785a66cee35553b15b5e8ce69deaee0838a09db4 /drivers/scsi/esp_scsi.h | |
| parent | scsi: mac_esp: Fix PIO transfers for MESSAGE IN phase (diff) | |
| download | linux-201c37d7bf121474ab08212ec0a1e9b163bdd74f.tar.xz linux-201c37d7bf121474ab08212ec0a1e9b163bdd74f.zip | |
scsi: esp_scsi: Clean up control flow and dead code
This patch improves readability. There are no functional changes.
Since this touches on a questionable ESP_INTR_DC conditional, add some
commentary to help others who may (as I did) find themselves chasing an
"Invalid Command" error after the device flags this condition.
This cleanup also eliminates a warning from "make W=1":
drivers/scsi/esp_scsi.c: In function 'esp_finish_select':
drivers/scsi/esp_scsi.c:1233:5: warning: variable 'orig_select_state' set but not used [-Wunused-but-set-variable]
u8 orig_select_state;
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/esp_scsi.h')
| -rw-r--r-- | drivers/scsi/esp_scsi.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/esp_scsi.h b/drivers/scsi/esp_scsi.h index 84dcbe4a6268..7e8932ae91f8 100644 --- a/drivers/scsi/esp_scsi.h +++ b/drivers/scsi/esp_scsi.h @@ -281,7 +281,6 @@ struct esp_cmd_entry { u8 flags; #define ESP_CMD_FLAG_WRITE 0x01 /* DMA is a write */ -#define ESP_CMD_FLAG_ABORT 0x02 /* being aborted */ #define ESP_CMD_FLAG_AUTOSENSE 0x04 /* Doing automatic REQUEST_SENSE */ #define ESP_CMD_FLAG_RESIDUAL 0x08 /* AM53c974 BLAST residual */ |