diff options
| author | John Garry <john.garry@huawei.com> | 2016-09-06 17:36:14 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2016-09-14 18:54:17 +0200 |
| commit | 59ba49f9d6ab0b265f692ae37d9787d6dbb39f00 (patch) | |
| tree | dba3301a016239289fa48690a491479a0bcc55e3 /drivers/scsi/hisi_sas | |
| parent | scsi: hisi_sas: keep CHL_INT2 masked for v2 HW (diff) | |
| download | linux-59ba49f9d6ab0b265f692ae37d9787d6dbb39f00.tar.xz linux-59ba49f9d6ab0b265f692ae37d9787d6dbb39f00.zip | |
scsi: hisi_sas: only zero slot memory when reused
Currently the slot memory is zeroed when it is freed and also when it is
reused, like in hisi_sas_task_prep(). Optimise by avoiding the redundant
zeroing in the free.
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/hisi_sas')
| -rw-r--r-- | drivers/scsi/hisi_sas/hisi_sas_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 5d5657670d4c..0e487517d08e 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -97,7 +97,7 @@ void hisi_sas_slot_task_free(struct hisi_hba *hisi_hba, struct sas_task *task, slot->task = NULL; slot->port = NULL; hisi_sas_slot_index_free(hisi_hba, slot->idx); - memset(slot, 0, sizeof(*slot)); + /* slot memory is fully zeroed when it is reused */ } EXPORT_SYMBOL_GPL(hisi_sas_slot_task_free); |