summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/hpsa.c
diff options
context:
space:
mode:
authorAlexey V. Vissarionov <gremlin@altlinux.org>2023-01-18 04:12:55 +0100
committerMartin K. Petersen <martin.petersen@oracle.com>2023-01-19 00:59:46 +0100
commitbbbd25499100c810ceaf5193c3cfcab9f7402a33 (patch)
treebd0c6aa4ce2a8eccded72ad9a73e3366052f048f /drivers/scsi/hpsa.c
parentscsi: target: core: Fix warning on RT kernels (diff)
downloadlinux-bbbd25499100c810ceaf5193c3cfcab9f7402a33.tar.xz
linux-bbbd25499100c810ceaf5193c3cfcab9f7402a33.zip
scsi: hpsa: Fix allocation size for scsi_host_alloc()
The 'h' is a pointer to struct ctlr_info, so it's just 4 or 8 bytes, while the structure itself is much bigger. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: edd163687ea5 ("hpsa: add driver for HP Smart Array controllers.") Link: https://lore.kernel.org/r/20230118031255.GE15213@altlinux.org Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org> Acked-by: Don Brace <don.brace@microchip.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/hpsa.c')
-rw-r--r--drivers/scsi/hpsa.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 4dbf51e2623a..f6da34850af9 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5850,7 +5850,7 @@ static int hpsa_scsi_host_alloc(struct ctlr_info *h)
{
struct Scsi_Host *sh;
- sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h));
+ sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info));
if (sh == NULL) {
dev_err(&h->pdev->dev, "scsi_host_alloc failed\n");
return -ENOMEM;