diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-11-11 05:30:12 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-11-26 00:36:23 +0100 |
| commit | fda34a5d304d0b98cc967e8763b52221b66dc202 (patch) | |
| tree | 8d9b581cec6f3bd5fc0aef8fa00e6c623231275f /drivers/scsi/hpsa.c | |
| parent | scsi: hpsa: Fix error handling in hpsa_add_sas_host() (diff) | |
| download | linux-fda34a5d304d0b98cc967e8763b52221b66dc202.tar.xz linux-fda34a5d304d0b98cc967e8763b52221b66dc202.zip | |
scsi: hpsa: Fix possible memory leak in hpsa_add_sas_device()
If hpsa_sas_port_add_rphy() returns an error, the 'rphy' allocated in
sas_end_device_alloc() needs to be freed. Address this by calling
sas_rphy_free() in the error path.
Fixes: d04e62b9d63a ("hpsa: add in sas transport class")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221111043012.1074466-1-yangyingliang@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/hpsa.c')
| -rw-r--r-- | drivers/scsi/hpsa.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6696967c5192..4dbf51e2623a 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -9823,10 +9823,12 @@ static int hpsa_add_sas_device(struct hpsa_sas_node *hpsa_sas_node, rc = hpsa_sas_port_add_rphy(hpsa_sas_port, rphy); if (rc) - goto free_sas_port; + goto free_sas_rphy; return 0; +free_sas_rphy: + sas_rphy_free(rphy); free_sas_port: hpsa_free_sas_port(hpsa_sas_port); device->sas_port = NULL; |