summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/hpsa.h
diff options
context:
space:
mode:
authorStephen M. Cameron <scameron@beardog.cce.hp.com>2011-05-03 21:58:49 +0200
committerJames Bottomley <jbottomley@parallels.com>2011-05-17 09:01:43 +0200
commitd0be5ec8693944c2e2fc0de70fda9dbc1b93bd7d (patch)
tree79052aef4a963d9cba5040662b98a2bbe77c7ff9 /drivers/scsi/hpsa.h
parent[SCSI] mptsas: Fix annoying warning (diff)
downloadlinux-d0be5ec8693944c2e2fc0de70fda9dbc1b93bd7d.tar.xz
linux-d0be5ec8693944c2e2fc0de70fda9dbc1b93bd7d.zip
[SCSI] hpsa: do readl after writel in main i/o path to ensure commands don't get lost.
Apparently we've been doin it rong for a decade, but only lately do we run into problems. Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com> Signed-off-by: James Bottomley <jbottomley@parallels.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to '')
-rw-r--r--drivers/scsi/hpsa.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index 621a1530054a..98c97ca21223 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -212,6 +212,7 @@ static void SA5_submit_command(struct ctlr_info *h,
dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr,
c->Header.Tag.lower);
writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
+ (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
h->commands_outstanding++;
if (h->commands_outstanding > h->max_outstanding)
h->max_outstanding = h->commands_outstanding;