diff options
author | Brian King <brking@linux.vnet.ibm.com> | 2014-10-30 23:27:10 +0100 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2015-01-19 10:46:20 +0100 |
commit | 6cdb08172bc89f0a39e1643c5e7eab362692fd1b (patch) | |
tree | 455a246fb286c335b737d14d03b3f50ef629d3c7 /drivers/scsi/ipr.h | |
parent | scsi: ->queue_rq can't sleep (diff) | |
download | linux-6cdb08172bc89f0a39e1643c5e7eab362692fd1b.tar.xz linux-6cdb08172bc89f0a39e1643c5e7eab362692fd1b.zip |
ipr: wait for aborted command responses
Fixes a race condition in abort handling that was injected
when multiple interrupt support was added. When only a single
interrupt is present, the adapter guarantees it will send
responses for aborted commands prior to the response for the
abort command itself. With multiple interrupts, these responses
generally come back on different interrupts, so we need to
ensure the abort thread waits until the aborted command is
complete so we don't perform a double completion. This race
condition was being hit frequently in environments which
were triggering command timeouts, which was resulting in
a double completion causing a kernel oops.
Cc: <stable@vger.kernel.org>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Reviewed-by: Wendy Xiong <wenxiong@linux.vnet.ibm.com>
Tested-by: Wendy Xiong <wenxiong@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/ipr.h')
-rw-r--r-- | drivers/scsi/ipr.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/ipr.h b/drivers/scsi/ipr.h index b4f3eec51bc9..ec03b42fa2b9 100644 --- a/drivers/scsi/ipr.h +++ b/drivers/scsi/ipr.h @@ -1606,6 +1606,7 @@ struct ipr_cmnd { struct scsi_device *sdev; } u; + struct completion *eh_comp; struct ipr_hrr_queue *hrrq; struct ipr_ioa_cfg *ioa_cfg; }; |