diff options
| author | Artem Chernyshev <artem.chernyshev@red-soft.ru> | 2023-11-28 13:11:59 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2023-12-06 03:13:15 +0100 |
| commit | 25cba909ade2a24f7356dc547dc417042bcef722 (patch) | |
| tree | d07d5c71f7801f55a5b342ddfd497bf9d06945dc /drivers/scsi/isci/task.c | |
| parent | scsi: ipr: Remove obsolete check for old CPUs (diff) | |
| download | linux-25cba909ade2a24f7356dc547dc417042bcef722.tar.xz linux-25cba909ade2a24f7356dc547dc417042bcef722.zip | |
scsi: isci: Remove redundant check in isci_task_request_build()
sci_task_request_construct_ssp() has invariant return. Change this function
to void and get rid of unnecessary checks.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Link: https://lore.kernel.org/r/20231128121159.2373975-1-artem.chernyshev@red-soft.ru
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/isci/task.c')
| -rw-r--r-- | drivers/scsi/isci/task.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/scsi/isci/task.c b/drivers/scsi/isci/task.c index c514b20293b2..3a25b1a2c52d 100644 --- a/drivers/scsi/isci/task.c +++ b/drivers/scsi/isci/task.c @@ -243,9 +243,7 @@ static struct isci_request *isci_task_request_build(struct isci_host *ihost, /* XXX convert to get this from task->tproto like other drivers */ if (dev->dev_type == SAS_END_DEVICE) { isci_tmf->proto = SAS_PROTOCOL_SSP; - status = sci_task_request_construct_ssp(ireq); - if (status != SCI_SUCCESS) - return NULL; + sci_task_request_construct_ssp(ireq); } return ireq; |