diff options
| author | Jean Delvare <jdelvare@suse.de> | 2009-03-05 21:45:55 +0100 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-03-13 21:25:53 +0100 |
| commit | f474a37bc48667595b5653a983b635c95ed82a3b (patch) | |
| tree | e8c61e0d9c09eb96eda58a2c68ede724e94d5879 /drivers/scsi/iscsi_tcp.c | |
| parent | [SCSI] fcoe: fcoe fc crc offload indication by skb->ip_summed (diff) | |
| download | linux-f474a37bc48667595b5653a983b635c95ed82a3b.tar.xz linux-f474a37bc48667595b5653a983b635c95ed82a3b.zip | |
[SCSI] libiscsi: fix iscsi pool error path
Memory freeing in iscsi_pool_free() looks wrong to me. Either q->pool
can be NULL and this should be tested before dereferencing it, or it
can't be NULL and it shouldn't be tested at all. As far as I can see,
the only case where q->pool is NULL is on early error in
iscsi_pool_init(). One possible way to fix the bug is thus to not
call iscsi_pool_free() in this case (nothing needs to be freed anyway)
and then we can get rid of the q->pool check.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi/iscsi_tcp.c')
0 files changed, 0 insertions, 0 deletions