summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/libfc
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-01-29 01:03:31 +0100
committerJames Bottomley <James.Bottomley@suse.de>2011-02-12 17:57:54 +0100
commite4a9a98289606392f2b1b24b4ca4e29154ec4d15 (patch)
tree2f2b31f1dddebe7a0bc6d8d97034272314861833 /drivers/scsi/libfc
parent[SCSI] libfc: Cleanup return paths in fc_rport_error_retry (diff)
downloadlinux-e4a9a98289606392f2b1b24b4ca4e29154ec4d15.tar.xz
linux-e4a9a98289606392f2b1b24b4ca4e29154ec4d15.zip
[SCSI] libfc:prevent dereferencing ERR_PTR in fc_tm_done()
If we goto out, then it tries to call kfree_skb() on an ERR_PTR which will oops. Just return directly. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/libfc')
-rw-r--r--drivers/scsi/libfc/fc_fcp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index ba639fad0a1c..f4eb1ab7b288 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
@@ -1323,7 +1323,7 @@ static void fc_tm_done(struct fc_seq *seq, struct fc_frame *fp, void *arg)
*
* scsi-eh will escalate for when either happens.
*/
- goto out;
+ return;
}
if (fc_fcp_lock_pkt(fsp))