diff options
| author | Tom Rix <trix@redhat.com> | 2020-06-27 15:32:42 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2020-06-30 03:34:35 +0200 |
| commit | 5aee52c44d9170591df65fafa1cd408acc1225ce (patch) | |
| tree | a5806e52c145d28172236607f59e6d0490403af9 /drivers/scsi/libiscsi.c | |
| parent | scsi: mptfusion: Don't use GFP_ATOMIC for larger DMA allocations (diff) | |
| download | linux-5aee52c44d9170591df65fafa1cd408acc1225ce.tar.xz linux-5aee52c44d9170591df65fafa1cd408acc1225ce.zip | |
scsi: scsi_transport_spi: Fix function pointer check
clang static analysis flags several null function pointer problems.
drivers/scsi/scsi_transport_spi.c:374:1: warning: Called function pointer is null (null dereference) [core.CallAndMessage]
spi_transport_max_attr(offset, "%d\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reviewing the store_spi_store_max macro
if (i->f->set_##field)
return -EINVAL;
should be
if (!i->f->set_##field)
return -EINVAL;
Link: https://lore.kernel.org/r/20200627133242.21618-1-trix@redhat.com
Reviewed-by: James Bottomley <jejb@linux.ibm.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/libiscsi.c')
0 files changed, 0 insertions, 0 deletions