summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/libiscsi_tcp.c
diff options
context:
space:
mode:
authorBart Van Assche <bart.vanassche@wdc.com>2017-12-04 19:36:31 +0100
committerMartin K. Petersen <martin.petersen@oracle.com>2017-12-08 03:06:58 +0100
commita44c9d36509c83cf64f33b93f6ab2e63822c01eb (patch)
treeede53055f843d13fe1cbf5d7b9d9dccf6c21e50d /drivers/scsi/libiscsi_tcp.c
parentscsi: core: Convert a source code comment into a runtime check (diff)
downloadlinux-a44c9d36509c83cf64f33b93f6ab2e63822c01eb.tar.xz
linux-a44c9d36509c83cf64f33b93f6ab2e63822c01eb.zip
scsi: core: scsi_get_device_flags_keyed(): Always return device flags
Since scsi_get_device_flags_keyed() callers do not check whether or not the returned value is an error code, change that function such that it returns a flags value even if the 'key' argument is invalid. Note: since commit 28a0bc4120d3 ("scsi: sd: Implement blacklist option for WRITE SAME w/ UNMAP") bit 31 is a valid device information flag so checking whether bit 31 is set in the return value is not sufficient to tell the difference between an error code and a flags value. Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.com> Cc: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/libiscsi_tcp.c')
0 files changed, 0 insertions, 0 deletions