summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/lpfc/lpfc_init.c
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2017-09-06 11:02:56 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2017-09-16 03:15:32 +0200
commit5c756065e47dc3e84b00577bd109f0a8e69903d7 (patch)
tree574d00cdb317daf16f0fc57397e233f2ebd7238e /drivers/scsi/lpfc/lpfc_init.c
parentscsi: aacraid: Fix 2T+ drives on SmartIOC-2000 (diff)
downloadlinux-5c756065e47dc3e84b00577bd109f0a8e69903d7.tar.xz
linux-5c756065e47dc3e84b00577bd109f0a8e69903d7.zip
scsi: lpfc: Don't return internal MBXERR_ERROR code from probe function
Internal error codes happen to be positive, thus the PCI driver core won't treat them as failure, but we do. This would cause a crash later on as lpfc_pci_remove_one() is called (e.g. as shutdown function). Fixes: 6d368e532168 ("[SCSI] lpfc 8.3.24: Add resource extent support") Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Acked-by: Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to '')
-rw-r--r--drivers/scsi/lpfc/lpfc_init.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 7e7ae786121b..100bc4c8798d 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -6131,6 +6131,7 @@ lpfc_sli4_driver_resource_setup(struct lpfc_hba *phba)
"Extents and RPI headers enabled.\n");
}
mempool_free(mboxq, phba->mbox_mem_pool);
+ rc = -EIO;
goto out_free_bsmbx;
}