diff options
| author | Christoph Hellwig <hch@lst.de> | 2005-10-31 19:51:24 +0100 |
|---|---|---|
| committer | James Bottomley <jejb@mulgrave.(none)> | 2005-11-06 19:50:41 +0100 |
| commit | 3072c4abdd8c239a28085733adf3aaae94ad8fbe (patch) | |
| tree | 4022443ea9bf6c8bbbb49c11eb67937c798b3f3f /drivers/scsi/megaraid | |
| parent | [SCSI] use a completion in scsi_send_eh_cmnd (diff) | |
| download | linux-3072c4abdd8c239a28085733adf3aaae94ad8fbe.tar.xz linux-3072c4abdd8c239a28085733adf3aaae94ad8fbe.zip | |
[SCSI] megaraid_sas: fix EH locking
recent kernels call the eh_ methods without the host lock held.
megaraid_sas doesn't need it but drops it before calling a sleeping
routine and reqcquires it afterwards. Just remove the
spin_unlock/spin_lock calls.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/megaraid')
| -rw-r--r-- | drivers/scsi/megaraid/megaraid_sas.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c index 4245d05e628b..2463f47adfda 100644 --- a/drivers/scsi/megaraid/megaraid_sas.c +++ b/drivers/scsi/megaraid/megaraid_sas.c @@ -767,17 +767,12 @@ static int megasas_generic_reset(struct scsi_cmnd *scmd) return FAILED; } - spin_unlock(scmd->device->host->host_lock); - ret_val = megasas_wait_for_outstanding(instance); - if (ret_val == SUCCESS) printk(KERN_NOTICE "megasas: reset successful \n"); else printk(KERN_ERR "megasas: failed to do reset\n"); - spin_lock(scmd->device->host->host_lock); - return ret_val; } |