diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2010-03-11 23:09:44 +0100 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2010-04-11 16:23:32 +0200 |
| commit | f3d6e1dcd291fd0da3accb0d60fbd0d26d2189ed (patch) | |
| tree | 8c5f8bb01cccd53aae7f4b5137e797b4b1de52f2 /drivers/scsi/pmcraid.c | |
| parent | [SCSI] gdth: fix buffer overflow (diff) | |
| download | linux-f3d6e1dcd291fd0da3accb0d60fbd0d26d2189ed.tar.xz linux-f3d6e1dcd291fd0da3accb0d60fbd0d26d2189ed.zip | |
[SCSI] pmcraid: redundant check in pmcraid_check_ioctl_buffer()
struct pmcraid_ioctl_header member buffer_length is unsigned, so this
check appears redundant.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Anil Ravindranath <anil_ravindranath@pmc-sierra.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/pmcraid.c')
| -rw-r--r-- | drivers/scsi/pmcraid.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index 53aefffbaead..c44e4ab4e938 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3751,12 +3751,6 @@ static int pmcraid_check_ioctl_buffer( return -EINVAL; } - /* buffer length can't be negetive */ - if (hdr->buffer_length < 0) { - pmcraid_err("ioctl: invalid buffer length specified\n"); - return -EINVAL; - } - /* check for appropriate buffer access */ if ((_IOC_DIR(cmd) & _IOC_READ) == _IOC_READ) access = VERIFY_WRITE; |