diff options
| author | Azeem Shaikh <azeemshaikh38@gmail.com> | 2023-05-17 16:35:09 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-05-26 22:52:19 +0200 |
| commit | 2f4113b330810ab71efa0bd4bbd0655154cd2a70 (patch) | |
| tree | ee5fa5b80356295728b46670e05d7e6dc3e00816 /drivers/scsi/qedi | |
| parent | scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy (diff) | |
| download | linux-2f4113b330810ab71efa0bd4bbd0655154cd2a70.tar.xz linux-2f4113b330810ab71efa0bd4bbd0655154cd2a70.zip | |
scsi: qedi: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517143509.1520387-1-azeemshaikh38@gmail.com
Diffstat (limited to 'drivers/scsi/qedi')
| -rw-r--r-- | drivers/scsi/qedi/qedi_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 45d359554182..450522b204d6 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -2593,7 +2593,7 @@ retry_probe: sp_params.drv_minor = QEDI_DRIVER_MINOR_VER; sp_params.drv_rev = QEDI_DRIVER_REV_VER; sp_params.drv_eng = QEDI_DRIVER_ENG_VER; - strlcpy(sp_params.name, "qedi iSCSI", QED_DRV_VER_STR_SIZE); + strscpy(sp_params.name, "qedi iSCSI", QED_DRV_VER_STR_SIZE); rc = qedi_ops->common->slowpath_start(qedi->cdev, &sp_params); if (rc) { QEDI_ERR(&qedi->dbg_ctx, "Cannot start slowpath\n"); |