diff options
| author | Benoit Taine <benoit.taine@lip6.fr> | 2014-05-26 17:21:16 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-05-28 18:13:19 +0200 |
| commit | c1818f17b58e416ec19653be430e9e2925cec35c (patch) | |
| tree | 4da70e730b3435747cae039c242d49d738c09b9f /drivers/scsi/qla2xxx/qla_mbx.c | |
| parent | qla4xxx: Use kmemdup instead of kmalloc + memcpy (diff) | |
| download | linux-c1818f17b58e416ec19653be430e9e2925cec35c.tar.xz linux-c1818f17b58e416ec19653be430e9e2925cec35c.zip | |
qla2xxx: Use kmemdup instead of kmalloc + memcpy
This issue was reported by coccicheck using the semantic patch
at scripts/coccinelle/api/memdup.cocci
Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_mbx.c')
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_mbx.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 7f39e3605027..1c33a77db5c2 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -1319,7 +1319,7 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len) left = 0; - list = kzalloc(dma_size, GFP_KERNEL); + list = kmemdup(pmap, dma_size, GFP_KERNEL); if (!list) { ql_log(ql_log_warn, vha, 0x1140, "%s(%ld): failed to allocate node names list " @@ -1328,7 +1328,6 @@ qla2x00_get_node_name_list(scsi_qla_host_t *vha, void **out_data, int *out_len) goto out_free; } - memcpy(list, pmap, dma_size); restart: dma_free_coherent(&ha->pdev->dev, dma_size, pmap, pmap_dma); } |