diff options
| author | Himanshu Madhani <himanshu.madhani@qlogic.com> | 2016-01-21 00:42:58 +0100 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2016-01-30 04:29:59 +0100 |
| commit | dacb58221805bb72ec46a73826c9e59a587d7d68 (patch) | |
| tree | 00726c4ecf60ef7064876e56195e780018a39af4 /drivers/scsi/qla2xxx | |
| parent | target: Fix WRITE_SAME/DISCARD conversion to linux 512b sectors (diff) | |
| download | linux-dacb58221805bb72ec46a73826c9e59a587d7d68.tar.xz linux-dacb58221805bb72ec46a73826c9e59a587d7d68.zip | |
qla2xxx: Fix warning reported by static checker
This patch fixes following warning
drivers/scsi/qla2xxx/qla_target.c:3587 qlt_do_ctio_completion()
warn: impossible condition '(logged_out == 41) => (0-1 == 41)'
drivers/scsi/qla2xxx/qla_target.c
3580 case CTIO_PORT_LOGGED_OUT:
3581 case CTIO_PORT_UNAVAILABLE:
3582 {
3583 bool logged_out = (status & 0xFFFF);
3584 ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
3585 "qla_target(%d): CTIO with %s status %x "
3586 "received (state %x, se_cmd %p)\n", vha->vp_idx,
3587 (logged_out == CTIO_PORT_LOGGED_OUT) ?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Bool cannot equal 0x26.
3588 "PORT LOGGED OUT" : "PORT UNAVAILABLE",
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/scsi/qla2xxx')
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_target.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 8075a4cdb45c..2c71305d2563 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -3580,12 +3580,13 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle, case CTIO_PORT_LOGGED_OUT: case CTIO_PORT_UNAVAILABLE: { - int logged_out = (status & 0xFFFF); + int logged_out = + (status & 0xFFFF) == CTIO_PORT_LOGGED_OUT; + ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059, "qla_target(%d): CTIO with %s status %x " "received (state %x, se_cmd %p)\n", vha->vp_idx, - (logged_out == CTIO_PORT_LOGGED_OUT) ? - "PORT LOGGED OUT" : "PORT UNAVAILABLE", + logged_out ? "PORT LOGGED OUT" : "PORT UNAVAILABLE", status, cmd->state, se_cmd); if (logged_out && cmd->sess) { |