diff options
| author | James Bottomley <James.Bottomley@suse.de> | 2010-08-06 22:17:24 +0200 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2010-08-11 06:58:33 +0200 |
| commit | 67110dfd45442e70753c575cf0509eaed237b749 (patch) | |
| tree | ae341419e616d3e44f1ab40675bbee5692c2cdfa /drivers/scsi/scsi_error.c | |
| parent | [SCSI] tgt: fix warning (diff) | |
| download | linux-67110dfd45442e70753c575cf0509eaed237b749.tar.xz linux-67110dfd45442e70753c575cf0509eaed237b749.zip | |
[SCSI] make error handling more robust in the face of reservations
commit 5f91bb050ecc4ff1d8d3d07edbe550c8f431c5e1
Author: Michael Reed <mdr@sgi.com>
Date: Mon Aug 10 11:59:28 2009 -0500
[SCSI] reservation conflict after timeout causes device to be taken offline
Flipped us from always returning failed to always returning success in
the name of fixing the problem where reservation conflict returns from
test unit ready cause the device always to be taken offline.
Unfortuantely, it also introduced a problem whereby for commands other
than test unit ready, the eh dispatcher thinks they succeeded when
reservation conflict is returned, whereas in reality they failed. Fix
this by only returning success for the test unit ready case.
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/scsi_error.c')
| -rw-r--r-- | drivers/scsi/scsi_error.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index cfd01ef8a9d4..0bd88381c1e1 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -473,10 +473,12 @@ static int scsi_eh_completed_normally(struct scsi_cmnd *scmd) */ return SUCCESS; case RESERVATION_CONFLICT: - /* - * let issuer deal with this, it could be just fine - */ - return SUCCESS; + if (scmd->cmnd[0] == TEST_UNIT_READY) + /* it is a success, we probed the device and + * found it */ + return SUCCESS; + /* otherwise, we failed to send the command */ + return FAILED; case QUEUE_FULL: scsi_handle_queue_full(scmd->device); /* fall through */ |