summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/scsi_lib.c
diff options
context:
space:
mode:
authorDaniel Axtens <dja@axtens.net>2017-05-10 22:11:39 +0200
committerIngo Molnar <mingo@kernel.org>2017-06-20 12:26:52 +0200
commitc5ae366e12b2bd56fc7d7e9d484836bec9ddc110 (patch)
tree1692a39f932899f7d3cc5fab6c94fe71b9e9803b /drivers/scsi/scsi_lib.c
parentsched/debug: Fix SCHED_WARN_ON() to return a value on !CONFIG_SCHED_DEBUG as ... (diff)
downloadlinux-c5ae366e12b2bd56fc7d7e9d484836bec9ddc110.tar.xz
linux-c5ae366e12b2bd56fc7d7e9d484836bec9ddc110.zip
sched/fair: WARN() and refuse to set buddy when !se->on_rq
If we set a next or last buddy for a se that is not on_rq, we will end up taking a NULL pointer dereference in wakeup_preempt_entity via pick_next_task_fair. Detect when we would be about to do that, throw a warning and then refuse to actually set it. This has been suggested at least twice: https://marc.info/?l=linux-kernel&m=146651668921468&w=2 https://lkml.org/lkml/2016/6/16/663 I recently had to debug a problem with these (we hadn't backported Konstantin's patches in this area) and this would have saved a lot of time/pain. Just do it. Signed-off-by: Daniel Axtens <dja@axtens.net> Cc: Ben Segall <bsegall@google.com> Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20170510201139.16236-1-dja@axtens.net Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/scsi/scsi_lib.c')
0 files changed, 0 insertions, 0 deletions