summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/scsi_transport_api.h
diff options
context:
space:
mode:
authorMahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>2013-10-31 09:31:02 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2013-11-20 01:27:39 +0100
commitb4789b8e6be3151a955ade74872822f30e8cd914 (patch)
tree070da93a2dea0db435ae935b90e73cb807440f79 /drivers/scsi/scsi_transport_api.h
parentMerge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (diff)
downloadlinux-b4789b8e6be3151a955ade74872822f30e8cd914.tar.xz
linux-b4789b8e6be3151a955ade74872822f30e8cd914.zip
aacraid: prevent invalid pointer dereference
It appears that driver runs into a problem here if fibsize is too small because we allocate user_srbcmd with fibsize size only but later we access it until user_srbcmd->sg.count to copy it over to srbcmd. It is not correct to test (fibsize < sizeof(*user_srbcmd)) because this structure already includes one sg element and this is not needed for commands without data. So, we would recommend to add the following (instead of test for fibsize == 0). Signed-off-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com> Reported-by: Nico Golde <nico@ngolde.de> Reported-by: Fabian Yamaguchi <fabs@goesec.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/scsi/scsi_transport_api.h')
0 files changed, 0 insertions, 0 deletions