diff options
| author | weiping zhang <zhangweiping@didichuxing.com> | 2017-10-12 08:56:44 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-10-17 07:26:03 +0200 |
| commit | 658e9a6dc1126f21fa417cd213e1cdbff8be0ba2 (patch) | |
| tree | 4cafb1b928b52e61fe7ecf07a190f68704e56d94 /drivers/scsi/sd.c | |
| parent | scsi: scsi_devinfo: fixup string compare (diff) | |
| download | linux-658e9a6dc1126f21fa417cd213e1cdbff8be0ba2.tar.xz linux-658e9a6dc1126f21fa417cd213e1cdbff8be0ba2.zip | |
scsi: sd: change allow_restart to bool in sysfs interface
/sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0
unexpectedly by writing an invalid string such as the following:
echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart
Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/sd.c')
| -rw-r--r-- | drivers/scsi/sd.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3ef221493d6c..ce9cc7afd095 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -253,6 +253,7 @@ static ssize_t allow_restart_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { + bool v; struct scsi_disk *sdkp = to_scsi_disk(dev); struct scsi_device *sdp = sdkp->device; @@ -262,7 +263,10 @@ allow_restart_store(struct device *dev, struct device_attribute *attr, if (sdp->type != TYPE_DISK && sdp->type != TYPE_ZBC) return -EINVAL; - sdp->allow_restart = simple_strtoul(buf, NULL, 10); + if (kstrtobool(buf, &v)) + return -EINVAL; + + sdp->allow_restart = v; return count; } |