diff options
| author | Stephen M. Cameron <scameron@beardog.cce.hp.com> | 2010-02-04 15:41:38 +0100 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@suse.de> | 2010-02-17 20:17:09 +0100 |
| commit | 82a72c0a12326a56a323093297e2bad29fe6c29d (patch) | |
| tree | 55d53ca69f8e3252b3824ec3e759f303bb5416a0 /drivers/scsi | |
| parent | [SCSI] hpsa: Use kernel integer types, not userland ones (diff) | |
| download | linux-82a72c0a12326a56a323093297e2bad29fe6c29d.tar.xz linux-82a72c0a12326a56a323093297e2bad29fe6c29d.zip | |
[SCSI] hpsa: avoid unwanted promotion from unsigned to signed for raid level index
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/hpsa.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 0f4a1f3c7e9f..ee9db5ee3cb1 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -431,7 +431,7 @@ static ssize_t raid_level_show(struct device *dev, struct device_attribute *attr, char *buf) { ssize_t l = 0; - int rlevel; + unsigned char rlevel; struct ctlr_info *h; struct scsi_device *sdev; struct hpsa_scsi_dev_t *hdev; @@ -455,7 +455,7 @@ static ssize_t raid_level_show(struct device *dev, rlevel = hdev->raid_level; spin_unlock_irqrestore(&h->lock, flags); - if (rlevel < 0 || rlevel > RAID_UNKNOWN) + if (rlevel > RAID_UNKNOWN) rlevel = RAID_UNKNOWN; l = snprintf(buf, PAGE_SIZE, "RAID %s\n", raid_label[rlevel]); return l; |