diff options
| author | kbuild test robot <lkp@intel.com> | 2020-03-28 12:07:28 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2020-04-01 04:35:02 +0200 |
| commit | 60f537d5755221efdcdae1415a4c745164c31214 (patch) | |
| tree | 74e777d9f75560194ef02a0bbf05c231b6c97dff /drivers/scsi | |
| parent | scsi: zfcp: use fallthrough; (diff) | |
| download | linux-60f537d5755221efdcdae1415a4c745164c31214.tar.xz linux-60f537d5755221efdcdae1415a4c745164c31214.zip | |
scsi: bnx2fc: fix boolreturn.cocci warnings
drivers/scsi/bnx2fc/bnx2fc_hwi.c:1019:9-10: WARNING: return of 0/1 in function 'bnx2fc_pending_work' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 77331115e220 ("scsi: bnx2fc: Process the RQE with CQE in interrupt context")
CC: Javed Hasan <jhasan@marvell.com>
Acked-by: Javed Hasan <jhasan@marvell.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/bnx2fc/bnx2fc_hwi.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c index eb41b0080f57..1f7c58b4c535 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c @@ -1016,7 +1016,7 @@ static bool bnx2fc_pending_work(struct bnx2fc_rport *tgt, unsigned int wqe) xid = wqe & FCOE_PEND_WQ_CQE_TASK_ID; if (xid >= hba->max_tasks) { pr_err(PFX "ERROR:xid out of range\n"); - return 0; + return false; } task_idx = xid / BNX2FC_TASKS_PER_PAGE; @@ -1059,14 +1059,14 @@ num_rq_zero: list_add_tail(&work->list, &fps->work_list); wake_up_process(fps->iothread); spin_unlock_bh(&fps->fp_work_lock); - return 1; + return true; } } spin_unlock_bh(&fps->fp_work_lock); bnx2fc_process_cq_compl(tgt, wqe, rq_data_buff, num_rq, task); - return 1; + return true; } int bnx2fc_process_new_cqes(struct bnx2fc_rport *tgt) |