diff options
| author | Azeem Shaikh <azeemshaikh38@gmail.com> | 2023-05-17 16:30:49 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-05-26 22:52:19 +0200 |
| commit | 038d40edc4c1038ce88c95a2d4f7cb46b9533bdd (patch) | |
| tree | d58a80a840aff5af6e39c4f5f27a804c08e9b66f /drivers/scsi | |
| parent | scsi: bnx2i: Replace all non-returning strlcpy with strscpy (diff) | |
| download | linux-038d40edc4c1038ce88c95a2d4f7cb46b9533bdd.tar.xz linux-038d40edc4c1038ce88c95a2d4f7cb46b9533bdd.zip | |
scsi: aacraid: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517143049.1519806-1-azeemshaikh38@gmail.com
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/aacraid/aachba.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 24c049eff157..70e1cac1975e 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -3289,7 +3289,7 @@ static int query_disk(struct aac_dev *dev, void __user *arg) else qd.unmapped = 0; - strlcpy(qd.name, fsa_dev_ptr[qd.cnum].devname, + strscpy(qd.name, fsa_dev_ptr[qd.cnum].devname, min(sizeof(qd.name), sizeof(fsa_dev_ptr[qd.cnum].devname) + 1)); if (copy_to_user(arg, &qd, sizeof (struct aac_query_disk))) |