diff options
author | Ming Lei <ming.lei@redhat.com> | 2018-04-11 12:47:44 +0200 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2018-04-11 15:59:15 +0200 |
commit | 2434af79c85d45d41d0c286fedf6e0556888a54c (patch) | |
tree | ce996ca4b97a75ad5cc0d7e3cd37ac0a3101eaed /drivers/scsi | |
parent | blk-mq: Avoid that submitting a bio concurrently with device removal triggers... (diff) | |
download | linux-2434af79c85d45d41d0c286fedf6e0556888a54c.tar.xz linux-2434af79c85d45d41d0c286fedf6e0556888a54c.zip |
blk-mq: Revert "blk-mq: reimplement blk_mq_hw_queue_mapped"
This reverts commit 127276c6ce5a30fcc806b7fe53015f4f89b62956.
When all CPUs of one hw queue become offline, there still may have IOs
not completed from this hctx. But blk_mq_hw_queue_mapped() is called in
blk_mq_queue_tag_busy_iter(), which is used for iterating request in timeout
handler, timeout event will be missed on the inactive hctx, then request may
never be completed.
Also the replementation of blk_mq_hw_queue_mapped() doesn't match the helper's
name any more, and it should have been named as blk_mq_hw_queue_active().
Even other callers need further verification about this reimplemenation.
So revert this patch now, and we can improve hw queue activate/inactivate event
after adequent researching and test.
Cc: Stefan Haberland <sth@linux.vnet.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>
Reported-by: Jens Axboe <axboe@kernel.dk>
Fixes: 127276c6ce5a30fcc ("blk-mq: reimplement blk_mq_hw_queue_mapped")
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/scsi')
0 files changed, 0 insertions, 0 deletions