diff options
| author | Herve Codina <herve.codina@bootlin.com> | 2023-12-05 16:21:00 +0100 |
|---|---|---|
| committer | Herve Codina <herve.codina@bootlin.com> | 2023-12-12 10:29:20 +0100 |
| commit | dfe66d012af2ddfa566cf9c860b8472b412fb7e4 (patch) | |
| tree | 247328a391faf4959ecd74c2c7ae22e52b771d02 /drivers/soc/fsl | |
| parent | soc: fsl: cpm1: qmc: Fix __iomem addresses declaration (diff) | |
| download | linux-dfe66d012af2ddfa566cf9c860b8472b412fb7e4.tar.xz linux-dfe66d012af2ddfa566cf9c860b8472b412fb7e4.zip | |
soc: fsl: cpm1: qmc: Fix rx channel reset
The qmc_chan_reset_rx() set the is_rx_stopped flag. This leads to an
inconsistent state in the following sequence.
qmc_chan_stop()
qmc_chan_reset()
Indeed, after the qmc_chan_reset() call, the channel must still be
stopped. Only a qmc_chan_start() call can move the channel from stopped
state to started state.
Fix the issue removing the is_rx_stopped flag setting from
qmc_chan_reset()
Fixes: 3178d58e0b97 ("soc: fsl: cpm1: Add support for QMC")
Cc: stable@vger.kernel.org
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/20231205152116.122512-4-herve.codina@bootlin.com
Diffstat (limited to 'drivers/soc/fsl')
| -rw-r--r-- | drivers/soc/fsl/qe/qmc.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index 3f3de1351c96..2312152a44b3 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -685,7 +685,6 @@ static void qmc_chan_reset_rx(struct qmc_chan *chan) qmc_read16(chan->s_param + QMC_SPE_RBASE)); chan->rx_pending = 0; - chan->is_rx_stopped = false; spin_unlock_irqrestore(&chan->rx_lock, flags); } |