diff options
| author | Sylwester Nawrocki <s.nawrocki@samsung.com> | 2019-08-21 17:05:39 +0200 |
|---|---|---|
| committer | Krzysztof Kozlowski <krzk@kernel.org> | 2019-08-22 20:15:38 +0200 |
| commit | 823034575c177d1d69673102a994d5d33b05e3de (patch) | |
| tree | a55ea78cc2536ef3a847f17db90ff4e51bd020c0 /drivers/soc/samsung | |
| parent | soc: samsung: chipid: Fix memory leak in error path (diff) | |
| download | linux-823034575c177d1d69673102a994d5d33b05e3de.tar.xz linux-823034575c177d1d69673102a994d5d33b05e3de.zip | |
soc: samsung: chipid: Remove the regmap lookup error log
In commit 40d8aff614f7 ("soc: samsung: chipid: Convert exynos-chipid
driver to use the regmap API") of_find_compatible_node() call was
substituted with syscon_regmap_lookup_by_compatible() but also an error
log was added for case where lookup fails. On multiplatform the lookup
will always fail on any non-samsung device so the log is incorrect.
Remove the error log and just return an error code from
syscon_regmap_lookup_by_compatible() which internally calls
of_find_compatible_node().
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Diffstat (limited to 'drivers/soc/samsung')
| -rw-r--r-- | drivers/soc/samsung/exynos-chipid.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index 75b6b880d9ef..c55a47cfe617 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -56,10 +56,8 @@ int __init exynos_chipid_early_init(void) int ret; regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); - if (IS_ERR(regmap)) { - pr_err("Failed to get CHIPID regmap\n"); + if (IS_ERR(regmap)) return PTR_ERR(regmap); - } ret = regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id); if (ret < 0) |