summaryrefslogtreecommitdiffstats
path: root/drivers/soundwire
diff options
context:
space:
mode:
authorRichard Fitzgerald <rf@opensource.cirrus.com>2022-09-17 17:48:21 +0200
committerVinod Koul <vkoul@kernel.org>2022-09-20 07:07:14 +0200
commit7f6bad4dfde0ec1d479fdcbbb62bccdbf3a93bb4 (patch)
treeff1c35ac01c03e2f2d3a67054de2f1bddd363fa7 /drivers/soundwire
parentsoundwire: cadence: Write to correct address for each FIFO chunk (diff)
downloadlinux-7f6bad4dfde0ec1d479fdcbbb62bccdbf3a93bb4.tar.xz
linux-7f6bad4dfde0ec1d479fdcbbb62bccdbf3a93bb4.zip
soundwire: cadence: Fix error check in cdns_xfer_msg()
_cdns_xfer_msg() returns an sdw_command_response value, not a negative error code. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20220917154822.690472-1-rf@opensource.cirrus.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire')
-rw-r--r--drivers/soundwire/cadence_master.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index ca241bbeadd9..3543a923ee6b 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -708,7 +708,7 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg)
for (i = 0; i < msg->len / CDNS_MCP_CMD_LEN; i++) {
ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN,
CDNS_MCP_CMD_LEN, false);
- if (ret < 0)
+ if (ret != SDW_CMD_OK)
goto exit;
}