summaryrefslogtreecommitdiffstats
path: root/drivers/spi/spi-cavium-thunderx.c
diff options
context:
space:
mode:
authorChuhong Yuan <hslester96@gmail.com>2019-12-06 08:55:00 +0100
committerMark Brown <broonie@kernel.org>2019-12-09 19:44:19 +0100
commita841e2853e1afecc2ee692b8cc5bff606bc84e4c (patch)
tree064156c38a0b87f19660d8f2fecbf019ddf4f78d /drivers/spi/spi-cavium-thunderx.c
parentspi: sprd: Fix the incorrect SPI register (diff)
downloadlinux-a841e2853e1afecc2ee692b8cc5bff606bc84e4c.tar.xz
linux-a841e2853e1afecc2ee692b8cc5bff606bc84e4c.zip
spi: spi-cavium-thunderx: Add missing pci_release_regions()
The driver forgets to call pci_release_regions() in probe failure and remove. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Link: https://lore.kernel.org/r/20191206075500.18525-1-hslester96@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-cavium-thunderx.c')
-rw-r--r--drivers/spi/spi-cavium-thunderx.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-cavium-thunderx.c b/drivers/spi/spi-cavium-thunderx.c
index d12e149f1a41..fd6b9caffaf0 100644
--- a/drivers/spi/spi-cavium-thunderx.c
+++ b/drivers/spi/spi-cavium-thunderx.c
@@ -82,6 +82,7 @@ static int thunderx_spi_probe(struct pci_dev *pdev,
error:
clk_disable_unprepare(p->clk);
+ pci_release_regions(pdev);
spi_master_put(master);
return ret;
}
@@ -96,6 +97,7 @@ static void thunderx_spi_remove(struct pci_dev *pdev)
return;
clk_disable_unprepare(p->clk);
+ pci_release_regions(pdev);
/* Put everything in a known state. */
writeq(0, p->register_base + OCTEON_SPI_CFG(p));
}