diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2014-08-06 14:58:58 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-08-17 00:13:53 +0200 |
| commit | 3819bc8752367eae0d72fa1c473dc88ea45631a7 (patch) | |
| tree | c3276922453c341ebe0ca35cf48f2d3c959d7bf2 /drivers/spi/spi-clps711x.c | |
| parent | Linux 3.17-rc1 (diff) | |
| download | linux-3819bc8752367eae0d72fa1c473dc88ea45631a7.tar.xz linux-3819bc8752367eae0d72fa1c473dc88ea45631a7.zip | |
spi: rspi: Fix leaking of unused DMA descriptors
If dmaengine_prep_slave_sg() or dmaengine_submit() fail, we may leak
unused DMA descriptors.
As per Documentation/dmaengine.txt, once a DMA descriptor has been
obtained, it must be submitted. Hence:
- First prepare and submit all DMA descriptors,
- Prepare the SPI controller for DMA,
- Start DMA by calling dma_async_issue_pending(),
- Make sure to call dmaengine_terminate_all() on all descriptors that
haven't completed.
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'drivers/spi/spi-clps711x.c')
0 files changed, 0 insertions, 0 deletions