diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-09-24 16:00:10 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2015-09-25 20:08:08 +0200 |
| commit | 8494cdea2223b66491df1264619e2205b4487913 (patch) | |
| tree | 7d515482c65ee860d229f3fc64ea5031bebe81c3 /drivers/spi/spi-davinci.c | |
| parent | Linux 4.3-rc1 (diff) | |
| download | linux-8494cdea2223b66491df1264619e2205b4487913.tar.xz linux-8494cdea2223b66491df1264619e2205b4487913.zip | |
spi: davinci: fix handling platform_get_irq result
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-davinci.c')
| -rw-r--r-- | drivers/spi/spi-davinci.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 3cf9faa6cc3f..a85d863d4a44 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -992,11 +992,12 @@ static int davinci_spi_probe(struct platform_device *pdev) goto free_master; } - dspi->irq = platform_get_irq(pdev, 0); - if (dspi->irq <= 0) { + ret = platform_get_irq(pdev, 0); + if (ret == 0) ret = -EINVAL; + if (ret < 0) goto free_master; - } + dspi->irq = ret; ret = devm_request_threaded_irq(&pdev->dev, dspi->irq, davinci_spi_irq, dummy_thread_fn, 0, dev_name(&pdev->dev), dspi); |