diff options
| author | Kees Cook <keescook@chromium.org> | 2020-06-03 22:28:45 +0200 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2020-07-16 21:32:25 +0200 |
| commit | b898ef6d15c04ac5ba453c1b3500b7420e73655a (patch) | |
| tree | 00bf2f6215a08b3525d09d795a52a205272532cf /drivers/spi/spi-davinci.c | |
| parent | b43: Remove uninitialized_var() usage (diff) | |
| download | linux-b898ef6d15c04ac5ba453c1b3500b7420e73655a.tar.xz linux-b898ef6d15c04ac5ba453c1b3500b7420e73655a.zip | |
rtlwifi: rtl8192cu: Remove uninitialized_var() usage
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings (e.g.
"unused variable"). If the compiler thinks it is uninitialized, either
simply initialize the variable or make compiler changes. As a precursor
to removing[2] this[3] macro[4], just initialize this variable to NULL,
and avoid sending garbage by returning.
[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Fixes: dc0313f46664 ("rtlwifi: rtl8192cu: Add routine hw")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'drivers/spi/spi-davinci.c')
0 files changed, 0 insertions, 0 deletions