diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2021-04-09 10:29:55 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-04-09 14:43:57 +0200 |
| commit | 9b844b087124c1538d05f40fda8a4fec75af55be (patch) | |
| tree | 61fc35a3d02ad44b81f0f0ae3752023910dea973 /drivers/spi/spi-dln2.c | |
| parent | spi: fsl: add missing iounmap() on error in of_fsl_spi_probe() (diff) | |
| download | linux-9b844b087124c1538d05f40fda8a4fec75af55be.tar.xz linux-9b844b087124c1538d05f40fda8a4fec75af55be.zip | |
spi: dln2: Fix reference leak to master
Call spi_master_get() holds the reference count to master device, thus
we need an additional spi_master_put() call to reduce the reference
count, otherwise we will leak a reference to master.
This commit fix it by removing the unnecessary spi_master_get().
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210409082955.2907950-1-weiyongjun1@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-dln2.c')
| -rw-r--r-- | drivers/spi/spi-dln2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c index 3902eadb892f..3ff63ab82f4f 100644 --- a/drivers/spi/spi-dln2.c +++ b/drivers/spi/spi-dln2.c @@ -781,7 +781,7 @@ exit_free_master: static int dln2_spi_remove(struct platform_device *pdev) { - struct spi_master *master = spi_master_get(platform_get_drvdata(pdev)); + struct spi_master *master = platform_get_drvdata(pdev); struct dln2_spi *dln2 = spi_master_get_devdata(master); pm_runtime_disable(&pdev->dev); |