diff options
| author | Serge Semin <Sergey.Semin@baikalelectronics.ru> | 2020-09-20 13:28:49 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-09-29 18:22:22 +0200 |
| commit | a128f6ecd56a32e559889145003425b0c7d406e3 (patch) | |
| tree | b5d7f13109c15e2700e2cb04b82e91cc18b8b60d /drivers/spi/spi-dw.h | |
| parent | spi: dw: Initialize n_bytes before the memory barrier (diff) | |
| download | linux-a128f6ecd56a32e559889145003425b0c7d406e3.tar.xz linux-a128f6ecd56a32e559889145003425b0c7d406e3.zip | |
spi: dw: Clear IRQ status on DW SPI controller reset
It turns out the IRQ status isn't cleared after switching the controller
off and getting it back on, which may cause raising false error interrupts
if controller has been unsuccessfully used by, for instance, a bootloader
before the driver is loaded. Let's explicitly clear the interrupts status
in the dedicated controller reset method.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Link: https://lore.kernel.org/r/20200920112914.26501-6-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-dw.h')
| -rw-r--r-- | drivers/spi/spi-dw.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h index 51bab30b9f85..6b30f5089218 100644 --- a/drivers/spi/spi-dw.h +++ b/drivers/spi/spi-dw.h @@ -230,14 +230,15 @@ static inline void spi_umask_intr(struct dw_spi *dws, u32 mask) } /* - * This does disable the SPI controller, interrupts, and re-enable the - * controller back. Transmit and receive FIFO buffers are cleared when the - * device is disabled. + * This disables the SPI controller, interrupts, clears the interrupts status, + * and re-enable the controller back. Transmit and receive FIFO buffers are + * cleared when the device is disabled. */ static inline void spi_reset_chip(struct dw_spi *dws) { spi_enable_chip(dws, 0); spi_mask_intr(dws, 0xff); + dw_readl(dws, DW_SPI_ICR); spi_enable_chip(dws, 1); } |