diff options
| author | Chris Packham <chris.packham@alliedtelesis.co.nz> | 2020-09-04 02:28:12 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-09-21 22:22:51 +0200 |
| commit | b867eef4cf548cd9541225aadcdcee644669b9e1 (patch) | |
| tree | ac92f7af5d92cf298e84498fbbf6e06ce2d6137d /drivers/spi/spi-fsl-espi.c | |
| parent | spi: bcm2835: Make polling_limit_us static (diff) | |
| download | linux-b867eef4cf548cd9541225aadcdcee644669b9e1.tar.xz linux-b867eef4cf548cd9541225aadcdcee644669b9e1.zip | |
spi: fsl-espi: Only process interrupts for expected events
The SPIE register contains counts for the TX FIFO so any time the irq
handler was invoked we would attempt to process the RX/TX fifos. Use the
SPIM value to mask the events so that we only process interrupts that
were expected.
This was a latent issue exposed by commit 3282a3da25bd ("powerpc/64:
Implement soft interrupt replay in C").
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20200904002812.7300-1-chris.packham@alliedtelesis.co.nz
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-fsl-espi.c')
| -rw-r--r-- | drivers/spi/spi-fsl-espi.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index e60581283a24..6d148ab70b93 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -564,13 +564,14 @@ static void fsl_espi_cpu_irq(struct fsl_espi *espi, u32 events) static irqreturn_t fsl_espi_irq(s32 irq, void *context_data) { struct fsl_espi *espi = context_data; - u32 events; + u32 events, mask; spin_lock(&espi->lock); /* Get interrupt events(tx/rx) */ events = fsl_espi_read_reg(espi, ESPI_SPIE); - if (!events) { + mask = fsl_espi_read_reg(espi, ESPI_SPIM); + if (!(events & mask)) { spin_unlock(&espi->lock); return IRQ_NONE; } |