diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-03-30 10:42:57 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-04-14 18:18:55 +0200 |
| commit | 7a40054361162d2f78f332aa868fed137beb7901 (patch) | |
| tree | 22f5adfbc063516d1dcdce19d49ae7b520d5d1f0 /drivers/spi/spi-fsl-spi.c | |
| parent | spi: fsl: Kill mpc8xxx_spi_cleanup and convert fsl_espi_setup to use devm_kza... (diff) | |
| download | linux-7a40054361162d2f78f332aa868fed137beb7901.tar.xz linux-7a40054361162d2f78f332aa868fed137beb7901.zip | |
spi: fsl-spi: Fix memory leak
mpc8xxx_spi_probe() has set master->cleanup = mpc8xxx_spi_cleanup,
however current code overrides the setting in fsl_spi_probe() and set
master->cleanup = fsl_spi_cleanup.
Thus the memory allocated for cs is not freed anywhere.
Convert to use devm_kzalloc to fix the memory leak.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'drivers/spi/spi-fsl-spi.c')
| -rw-r--r-- | drivers/spi/spi-fsl-spi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c index b3e7775034db..98ccd231bf00 100644 --- a/drivers/spi/spi-fsl-spi.c +++ b/drivers/spi/spi-fsl-spi.c @@ -431,7 +431,7 @@ static int fsl_spi_setup(struct spi_device *spi) return -EINVAL; if (!cs) { - cs = kzalloc(sizeof *cs, GFP_KERNEL); + cs = devm_kzalloc(&spi->dev, sizeof(*cs), GFP_KERNEL); if (!cs) return -ENOMEM; spi->controller_state = cs; |