diff options
| author | Jay Fang <f.fangjian@huawei.com> | 2021-05-10 08:58:21 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-05-10 14:07:51 +0200 |
| commit | 856a9260e17129303102a7d4a5f71b7a8739e5b9 (patch) | |
| tree | 3655ef42b059f8a170581cb23742a8e62268622d /drivers/spi/spi-omap-100k.c | |
| parent | spi: ppc4xx: include <linux/io.h> instead of <asm/io.h> (diff) | |
| download | linux-856a9260e17129303102a7d4a5f71b7a8739e5b9.tar.xz linux-856a9260e17129303102a7d4a5f71b7a8739e5b9.zip | |
spi: omap-100k: Clean the value of 'status' is not used
An error code is set to 'status' before exiting list_for_each_entry()
loop, but the value of 'status' is not used as below:
list_for_each_entry(t, &m->transfers, transfer_list) {
if (t->tx_buf == NULL && t->rx_buf == NULL && t->len) {
status = -EINVAL;
break;
}
...
}
status = omap1_spi100k_setup_transfer(spi, NULL);
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
Link: https://lore.kernel.org/r/1620629903-15493-3-git-send-email-f.fangjian@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-omap-100k.c')
| -rw-r--r-- | drivers/spi/spi-omap-100k.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c index 7062f2902253..dc9b86b648ac 100644 --- a/drivers/spi/spi-omap-100k.c +++ b/drivers/spi/spi-omap-100k.c @@ -296,7 +296,6 @@ static int omap1_spi100k_transfer_one_message(struct spi_master *master, list_for_each_entry(t, &m->transfers, transfer_list) { if (t->tx_buf == NULL && t->rx_buf == NULL && t->len) { - status = -EINVAL; break; } status = omap1_spi100k_setup_transfer(spi, t); @@ -315,7 +314,6 @@ static int omap1_spi100k_transfer_one_message(struct spi_master *master, m->actual_length += count; if (count != t->len) { - status = -EIO; break; } } |