diff options
| author | Thomas Perrot <thomas.perrot@bootlin.com> | 2021-10-22 16:21:04 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-26 12:53:57 +0200 |
| commit | d81d0e41ed5fe7229a2c9a29d13bad288c7cf2d2 (patch) | |
| tree | b9fc95295c9539dac0c84609a97465df04a538ef /drivers/spi/spi-pl022.c | |
| parent | spi: altera: Change to dynamic allocation of spi id (diff) | |
| download | linux-d81d0e41ed5fe7229a2c9a29d13bad288c7cf2d2.tar.xz linux-d81d0e41ed5fe7229a2c9a29d13bad288c7cf2d2.zip | |
spi: spl022: fix Microwire full duplex mode
There are missing braces in the function that verify controller parameters,
then an error is always returned when the parameter to select Microwire
frames operation is used on devices allowing it.
Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
Link: https://lore.kernel.org/r/20211022142104.1386379-1-thomas.perrot@bootlin.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-pl022.c')
| -rw-r--r-- | drivers/spi/spi-pl022.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index feebda66f56e..e4484ace584e 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -1716,12 +1716,13 @@ static int verify_controller_parameters(struct pl022 *pl022, return -EINVAL; } } else { - if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) + if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) { dev_err(&pl022->adev->dev, "Microwire half duplex mode requested," " but this is only available in the" " ST version of PL022\n"); - return -EINVAL; + return -EINVAL; + } } } return 0; |