diff options
| author | Xingbang Liu <liu.airalert@gmail.com> | 2022-03-02 08:15:21 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-03-07 14:16:08 +0100 |
| commit | fa0f3db49e10ac61774e1c90167ec79429d6fd56 (patch) | |
| tree | dbc28618523a34dda7db5821533e469a1d2043e6 /drivers/spi/spi-qup.c | |
| parent | spi: cadence: fix platform_get_irq.cocci warning (diff) | |
| download | linux-fa0f3db49e10ac61774e1c90167ec79429d6fd56.tar.xz linux-fa0f3db49e10ac61774e1c90167ec79429d6fd56.zip | |
spi: qup: replace spin_lock_irqsave by spin_lock in hard IRQ
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Xingbang Liu <liu.airalert@gmail.com>
Link: https://lore.kernel.org/r/20220302071521.6638-1-liu.airalert@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-qup.c')
| -rw-r--r-- | drivers/spi/spi-qup.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index d39dec6d1c91..00d6084306b4 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -593,7 +593,6 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) { struct spi_qup *controller = dev_id; u32 opflags, qup_err, spi_err; - unsigned long flags; int error = 0; qup_err = readl_relaxed(controller->base + QUP_ERROR_FLAGS); @@ -625,10 +624,10 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) error = -EIO; } - spin_lock_irqsave(&controller->lock, flags); + spin_lock(&controller->lock); if (!controller->error) controller->error = error; - spin_unlock_irqrestore(&controller->lock, flags); + spin_unlock(&controller->lock); if (spi_qup_is_dma_xfer(controller->mode)) { writel_relaxed(opflags, controller->base + QUP_OPERATIONAL); |