summaryrefslogtreecommitdiffstats
path: root/drivers/spi/spi-rockchip.c
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2014-07-20 16:02:04 +0200
committerMark Brown <broonie@linaro.org>2014-07-25 19:25:59 +0200
commitdb7e8d90cae5d0840ad1444b693ec43dbfab339f (patch)
tree103b54653162f5b0d8157606aa26240ab1721f95 /drivers/spi/spi-rockchip.c
parentspi/rockchip: remove redundant dev_err call in rockchip_spi_probe() (diff)
downloadlinux-db7e8d90cae5d0840ad1444b693ec43dbfab339f.tar.xz
linux-db7e8d90cae5d0840ad1444b693ec43dbfab339f.zip
spi/rockchip: fix error return code in rockchip_spi_probe()
Fix to return -EINVAL from the error handling case instead of 0 when failed to get fifo length. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'drivers/spi/spi-rockchip.c')
-rw-r--r--drivers/spi/spi-rockchip.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 47c9168f18b2..c0743604b906 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -640,6 +640,7 @@ static int rockchip_spi_probe(struct platform_device *pdev)
rs->fifo_len = get_fifo_len(rs);
if (!rs->fifo_len) {
dev_err(&pdev->dev, "Failed to get fifo length\n");
+ ret = -EINVAL;
goto err_get_fifo_len;
}