diff options
| author | Patrice Chotard <patrice.chotard@st.com> | 2020-04-29 12:26:25 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-04-29 19:52:16 +0200 |
| commit | be6ef160840f23d9723d9bd008ca08e864ce4745 (patch) | |
| tree | 010c7da55e33b8572c011094abfef53d74af0c45 /drivers/spi/spi-stm32-qspi.c | |
| parent | spi: uniphier: fix error return code in uniphier_spi_probe() (diff) | |
| download | linux-be6ef160840f23d9723d9bd008ca08e864ce4745.tar.xz linux-be6ef160840f23d9723d9bd008ca08e864ce4745.zip | |
spi: stm32-qspi: Fix unbalanced pm_runtime_enable issue
Issue detected by unbinding/binding the stm32 qspi driver as following:
root@stm32mp2:~# echo 40430000.spi > /sys/bus/platform/drivers/stm32-qspi/404300
00.spi/driver/unbind
root@stm32mp2:~# echo 40430000.spi > /sys/bus/platform/drivers/stm32-qspi/bind
[ 969.864021] stm32-qspi 40430000.spi: Unbalanced pm_runtime_enable!
[ 970.225161] spi-nor spi0.0: mx66u51235f (65536 Kbytes)
[ 970.935721] spi-nor spi0.1: mx66u51235f (65536 Kbytes)
Fixes: 9d282c17b023 ("spi: stm32-qspi: Add pm_runtime support")
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Link: https://lore.kernel.org/r/20200429102625.25974-1-patrice.chotard@st.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-stm32-qspi.c')
| -rw-r--r-- | drivers/spi/spi-stm32-qspi.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 2f2ea2c42d6e..3c44bb2fd9b1 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -555,10 +555,15 @@ static const struct spi_controller_mem_ops stm32_qspi_mem_ops = { static void stm32_qspi_release(struct stm32_qspi *qspi) { + pm_runtime_get_sync(qspi->dev); /* disable qspi */ writel_relaxed(0, qspi->io_base + QSPI_CR); stm32_qspi_dma_free(qspi); mutex_destroy(&qspi->lock); + pm_runtime_put_noidle(qspi->dev); + pm_runtime_disable(qspi->dev); + pm_runtime_set_suspended(qspi->dev); + pm_runtime_dont_use_autosuspend(qspi->dev); clk_disable_unprepare(qspi->clk); } |