diff options
| author | Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-03 15:13:45 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-11-09 20:44:27 +0100 |
| commit | 763eab7074f6e71babd85d796156f05a675f9510 (patch) | |
| tree | c50d5bb0f443310792bf508a6d303b30a275dff9 /drivers/spi/spi-tegra20-slink.c | |
| parent | spi: mt7621: fix missing clk_disable_unprepare() on error in mt7621_spi_probe (diff) | |
| download | linux-763eab7074f6e71babd85d796156f05a675f9510.tar.xz linux-763eab7074f6e71babd85d796156f05a675f9510.zip | |
spi: tegra20-slink: fix reference leak in slink ops of tegra20
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in two callers(tegra_slink_setup and
tegra_slink_resume), so we should fix it.
Fixes: dc4dc36056392 ("spi: tegra: add spi driver for SLINK controller")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103141345.6188-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-tegra20-slink.c')
| -rw-r--r-- | drivers/spi/spi-tegra20-slink.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c index a0810765d4e5..f7c832fd4003 100644 --- a/drivers/spi/spi-tegra20-slink.c +++ b/drivers/spi/spi-tegra20-slink.c @@ -751,6 +751,7 @@ static int tegra_slink_setup(struct spi_device *spi) ret = pm_runtime_get_sync(tspi->dev); if (ret < 0) { + pm_runtime_put_noidle(tspi->dev); dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret); return ret; } @@ -1188,6 +1189,7 @@ static int tegra_slink_resume(struct device *dev) ret = pm_runtime_get_sync(dev); if (ret < 0) { + pm_runtime_put_noidle(dev); dev_err(dev, "pm runtime failed, e = %d\n", ret); return ret; } |